fixup-libgfortran.sh: Use patchelf instead of parsing ldd output
#34155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be less brittle, and even better, work on `musl` Also ask `$FC` where `libgfortran` lives if we have no dirname Ask `libgfortran` where to get its libraries, don't rely on recursive dep printing
|
@rana @shabmk As the two users in JuliaCI/julia-buildbot#102 that have expressed interest in musl CI/CD, do builds of this branch locally pass tests for you? I'm thinking there might be something wrong with our BinaryBuilder libgit2 binaries, seeing as those tests seem to fail immediately with I/O errors. |
I don't think our libgit2 has ever worked for musl. See also #28805. |
|
Moved on without |
I tested in a Docker container (Alpine 3.9) and I encountered a total of 9 failures (all from the file testset) and 10 errors (2 in Sockets due to running in Docker). I did get that same I/O error from libgit2 but oddly enough I did not hit #28805. |
|
This issue was brought to my attention. I compiled this branch on my musl-native system. The I ran the tests. |
|
Full long in case it helps |
|
Is it possible this broke something on Aarch64? After rebasing #34326 on master (which includes this PR), testing failed: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be less brittle, and even better, work on
muslAlso ask
$FCwherelibgfortranlives if we have no dirnameAsk
libgfortranwhere to get its libraries, don't rely on recursive dep printing